gr2m / gr2m/github-project

Throw error in case multiple fields / field options are matched

Aperta
#32 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
bug Pull Request welcome
Lingua principale
JavaScript
Stelle
36
Fork
10
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

### Please avoid duplicates

- [X] I checked [all open bugs](https://github.com/gr2m/github-project/issues?q=is%3Aissue+is%3Aopen+label%3Abug) and none of them matched my problem.

### Reproducible test case

_No response_

### Please select the environment(s) that are relevant to your bug report

- [X] Browsers
- [X] Node
- [X] Deno

### Versions

1.3.1

### What happened?

In theory, a field configured in the `fields` constructor option can be matched to multiple project fields when using [the `matchFieldName` constructor option](https://github.com/gr2m/github-project/#constructor). The same is true for matching field options and the `matchFieldOptionValue` option.

I think right now the first match wins. But what we should do instead in both cases is to match all fields / field options respectively and verify that there is exactly one match. We throw an error if there is no match. We should also throw an error if there is more than one match

### Would you be interested in contributing a fix?

- [ ] yes

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.