googlemaps / googlemaps/android-maps-compose

Create lint rules for Maps Compose

Aperta
#218 1 commento 0 reazioni 0 assegnatari Vedi su GitHub
priority: p3 type: feature request
Lingua principale
Kotlin
Stelle
1.3k
Fork
181
Merge medio
2g 23h
PR unite (30g)
18

Descrizione

**Is your feature request related to a problem? Please describe.**
Maps Compose has frequently changing state that should not be read in composition. Example of this are:
* `MarkerPositionState.positon` - this changes frequently when a marker is dragged
* `CameraPositionState.position` - this changes frequently as the map's camera changes

**Describe the solution you'd like**
Provide lint rules that give warnings when the state mentioned above is read within composition.

**Describe alternatives you've considered**
Do nothing.

**Additional context**
Take a look at https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:compose/foundation/foundation-lint/src/test/java/androidx/compose/foundation/lint/LazyLayoutStateReadInCompositionDetectorTest.kt?q=firstVisibleItemIndex&start=21 and https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:compose/foundation/foundation-lint/src/main/java/androidx/compose/foundation/lint/LazyLayoutStateReadInCompositionDetector.kt;l=40?q=LazyLayoutStateReadInCom&sq= as an example

Guida per i contributori

Apri la guida per i contributori

Direzione di ricerca

Start by reading the referenced LazyLayoutStateReadInCompositionDetector and LazyLayoutStateReadInCompositionDetectorTest examples. Identify the Maps Compose state properties named in the issue and determine how a lint detector can warn when they are read during composition. Done means tests cover the warnings and the lint rules flag those reads.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
kotlin
Ambito
tooling
Tipo di issue
Funzionalità
Difficoltà
4/5
Tempo stimato
3-5 giorni
Stato di attività
Ferma
Chiarezza
Abbastanza chiara
Idoneità per principianti
35/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.