googleapis / googleapis/java-storage

Feature request: expose ChannelPoolSettings on GrpcStorageOptions.Builder

Abierto
#3,553 0 comentarios 0 reacciones 0 asignados Ver en GitHub
api: storage
Lenguaje dominante
Java
Estrellas
141
Forks
93
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

## Is your feature request related to a problem? Please describe.

We use `StorageOptions.grpc()` with Direct Path on GKE for high-throughput writes (`WriteChannel`, resumable uploads). A single commit can trigger **hundreds of concurrent uploads** per pod.

`GrpcStorageOptions` builds `InstantiatingGrpcChannelProvider` without `setChannelPoolSettings()`, so the default is effectively **one gRPC channel**. With ~100+ concurrent RPCs, calls queue on that channel and we see high tail latency and underused bandwidth.

`ChannelPoolSettings` can be set on `StorageSettings` + `StorageClient`, but the high-level `Storage` API from `StorageOptions.grpc().build().getService()` offers no way to pass those settings.

(`google-cloud-storage` 2.34.0+, resolves to 2.55.x in our build.)

## Describe the solution you'd like

Add `setChannelPoolSettings(ChannelPoolSettings)` to `GrpcStorageOptions.Builder`, wired through to `InstantiatingGrpcChannelProvider` in `resolveSettingsAndOpts()`. Default unchanged when unset.

```java
Storage storage = StorageOptions.grpc()
.setProjectId(projectId)
.setChannelPoolSettings(ChannelPoolSettings.builder()
.setInitialChannelCount(8)
.setMaxChannelCount(16)
.setMaxRpcsPerChannel(50)
.build())
.build()
.getService();
```

## Describe alternatives you've considered

- **`StorageClient` + custom `StorageSettings`** — channel pool works, but not compatible with high-level `Storage` / `WriteChannel`.
- **Copy `resolveSettingsAndOpts()` in app code** — fragile.
- **Upload concurrency limit in app** — does not fix single-channel RPC queuing.

Guía de contribución

Abrir la guía de contribución

Línea de trabajo

Comienza en GrpcStorageOptions.Builder y sigue resolveSettingsAndOpts() para ver cómo se configura InstantiatingGrpcChannelProvider. Añade la configuración solicitada del builder y verifica que StorageOptions.grpc().build().getService() la acepta, mientras el comportamiento permanece sin cambios cuando la configuración no está establecida.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
grpc, java
Área
api, backend
Tipo de issue
Nueva funcionalidad
Dificultad
3/5
Tiempo estimado
1-2 días
Estado de actividad
Tranquilo
Claridad
Bien especificado
Aptitud para principiantes
76/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.