googleapis / googleapis/java-storage

Feature request: expose ChannelPoolSettings on GrpcStorageOptions.Builder

Open
#3,553 0 comments 0 reactions 0 assignees View on GitHub
api: storage
Dominant language
Java
Stars
141
Forks
93
PR merge metrics
No merged PRs in 30d

Description

## Is your feature request related to a problem? Please describe.

We use `StorageOptions.grpc()` with Direct Path on GKE for high-throughput writes (`WriteChannel`, resumable uploads). A single commit can trigger **hundreds of concurrent uploads** per pod.

`GrpcStorageOptions` builds `InstantiatingGrpcChannelProvider` without `setChannelPoolSettings()`, so the default is effectively **one gRPC channel**. With ~100+ concurrent RPCs, calls queue on that channel and we see high tail latency and underused bandwidth.

`ChannelPoolSettings` can be set on `StorageSettings` + `StorageClient`, but the high-level `Storage` API from `StorageOptions.grpc().build().getService()` offers no way to pass those settings.

(`google-cloud-storage` 2.34.0+, resolves to 2.55.x in our build.)

## Describe the solution you'd like

Add `setChannelPoolSettings(ChannelPoolSettings)` to `GrpcStorageOptions.Builder`, wired through to `InstantiatingGrpcChannelProvider` in `resolveSettingsAndOpts()`. Default unchanged when unset.

```java
Storage storage = StorageOptions.grpc()
.setProjectId(projectId)
.setChannelPoolSettings(ChannelPoolSettings.builder()
.setInitialChannelCount(8)
.setMaxChannelCount(16)
.setMaxRpcsPerChannel(50)
.build())
.build()
.getService();
```

## Describe alternatives you've considered

- **`StorageClient` + custom `StorageSettings`** — channel pool works, but not compatible with high-level `Storage` / `WriteChannel`.
- **Copy `resolveSettingsAndOpts()` in app code** — fragile.
- **Upload concurrency limit in app** — does not fix single-channel RPC queuing.

Contributor guide

Open the contributing guide

Research direction

Start in GrpcStorageOptions.Builder and follow resolveSettingsAndOpts() to see how InstantiatingGrpcChannelProvider is configured. Add the requested builder setting and verify that StorageOptions.grpc().build().getService() accepts it while behavior remains unchanged when the setting is unset.

Written by the indexing model from the issue text.

Assessment

Tech stack
grpc, java
Domain
api, backend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
76/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.