googleapis / googleapis/java-bigtable-hbase
OneOf is set multiple times with different values
- Vorherrschende Sprache
- Java
- Sterne
- 184
- Forks
- 184
- Ø Merge
- 10 Std.
- Gemergte PRs (30 T.)
- 6
Beschreibung
These calls to OneOf setters in `BigtableTableAdminClientWrapper.java` overwrite previously set values:
https://github.com/googleapis/java-bigtable-hbase/blob/d3403e14cf0463d39e71d1af62a81f3c4110d125/bigtable-client-core-parent/bigtable-client-core/src/main/java/com/google/cloud/bigtable/grpc/BigtableTableAdminClientWrapper.java#L240
https://github.com/googleapis/java-bigtable-hbase/blob/d3403e14cf0463d39e71d1af62a81f3c4110d125/bigtable-client-core-parent/bigtable-client-core/src/main/java/com/google/cloud/bigtable/grpc/BigtableTableAdminClientWrapper.java#L258
This was noticed because of an [Error Prone static check](https://errorprone.info/bugpattern/RedundantSetterCall), which reports the following error for that code:
```
src/main/java/com/google/cloud/bigtable/grpc/BigtableTableAdminClientWrapper.java:240: error: [RedundantSetterCall] The oneof `Target` (set via setDeleteAllDataFromTable, setRowKeyPrefix) was called twice with . Setting the same field multiple times is redundant, and could mask a bug.
.setRowKeyPrefix(rowKeyPrefix)
^
(see https://errorprone.info/bugpattern/RedundantSetterCall)
src/main/java/com/google/cloud/bigtable/grpc/BigtableTableAdminClientWrapper.java:258: error: [RedundantSetterCall] The oneof `Target` (set via setDeleteAllDataFromTable, setRowKeyPrefix) was called twice with . Setting the same field multiple times is redundant, and could mask a bug.
.setRowKeyPrefix(rowKeyPrefix)
^
(see https://errorprone.info/bugpattern/RedundantSetterCall)
```
Beitragsleitfaden
Rechercherichtung
Beginne in bigtable-client-core-parent/bigtable-client-core/src/main/java/com/google/cloud/bigtable/grpc/BigtableTableAdminClientWrapper.java bei den Aufrufen in der Nähe der Zeilen 240 und 258. Lies die umgebende OneOf-Zielkonstruktion und führe die Prüfung Error Prone RedundantSetterCall aus. Fertig ist es, wenn die Warnungen zu redundanten Setter-Aufrufen behoben sind, ohne das beabsichtigte Zielverhalten zu ändern.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- java
- Bereich
- database
- Issue-Typ
- Bug
- Schwierigkeit
- 2/5
- Geschätzter Aufwand
- 1-3 Stunden
- Aktivitätsstatus
- Veraltet
- Klarheit
- Größtenteils klar
- Anfängerfreundlichkeit
- 68/100