googleapis / googleapis/google-http-java-client

Add java.time.Duration-based APIs

Open
#776 1 comment 0 reactions 0 assignees View on GitHub
semver: minor status: blocked type: cleanup
Dominant language
Java
Stars
1.4k
Forks
473
PR merge metrics
No merged PRs in 30d

Description

Representing date/time concepts as numeric primitives is a bad idea. It leads to unit mismatch, overflows, and many other dangerous date/time-related bugs.

For instance, it's impossible to tell what time unit `readTimeout` is without reading it's javadocs:
```java
public final class HttpRequest {
public HttpRequest setReadTimeout(int readTimeout) { ... }
}
```

Please consider adding `java.time.Duration` overloads to all APIs that accept a date/time concept as a numeric primitive. Methods that _return_ a numeric primitive representing a date/time concept are much more difficult as new, alternative method names must be chosen (e.g., `public int getReadTimeout()`).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.