googleapis / googleapis/google-cloud-python

auth: configure_mtls_channel() discards existing session configuration

Aperta
#18,314 0 commenti 0 reazioni 1 assegnatario Rivendicata da @agrawalradhika-cell Vedi su GitHub
priority: p2 type: bug
Lingua principale
Python
Stelle
5.4k
Fork
1.8k
Merge medio
3g 4h
PR unite (30g)
122

Descrizione

In `AsyncAuthorizedSession.configure_mtls_channel()` (`packages/google-auth/google/auth/aio/transport/sessions.py`), configuring mutual TLS replaces `self._auth_request` with a newly constructed `aiohttp.ClientSession` and `aiohttp.TCPConnector`:

```python
connector = aiohttp.TCPConnector(ssl=ssl_context)
new_session = aiohttp.ClientSession(connector=connector)
old_auth_request = self._auth_request
self._auth_request = AiohttpRequest(session=new_session)
```

Because `new_session` is instantiated from scratch with default arguments, we lose any custom configurations provided by callers on the initial session, such as connection pool limits, timeouts, etc.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.