googleapis / googleapis/google-cloud-python

bug: update the internal logic in resolve_feature_flags

Open
#18,214 0 comments 0 reactions 1 assignee Claimed by @chalmerlowe View on GitHub
type: bug
Dominant language
Python
Stars
5.4k
Forks
1.8k
Avg merge
3d 4h
Merged PRs (30d)
122

Description

### Determine this is the right repository

- [x] I determined this is the correct repository in which to report this bug.

### Summary of the issue

Expand upon the logic in the Feature Gating LLD (internal doc) and the current `resolve_feature_flags()` implementation to better handle nuances between how opentelemetry (OTEL) handles the value `None` and how Python handles the value `None`.

Namely, OTEL tends to use `None` in functions such as `get_tracer()` to mean: use the default provider, whereas to a Pythonista we might interpret `None` to mean don't use a provider, don't do anything, leave tracing disabled.

This conflict should be resolved in the LLD and a future PR.

### API client name and version

_No response_

### Reproduction steps: code

### Reproduction steps: supporting files

### Reproduction steps: actual results

### Reproduction steps: expected results

_No response_

### OS & version + platform

_No response_

### Python environment

_No response_

### Python dependencies

_No response_

### Additional context

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.