googleapis / googleapis/google-cloud-python

Remove setup_request_id fallback in generated packages when google-api-core >= 2.26.0

未关闭
#17,813 0 条评论 0 个 reaction 已指派 1 人 已被 @hebaalazzeh 认领 在 GitHub 查看
主要语言
Python
星标
5.4k
派生
1.8k
平均合并
3 天 4 小时
30 天内合并 PR
122

描述

## Overview

During the GAPIC request-id deduplication effort (centralizing request ID generation into `google.api_core.gapic_v1.requests.setup_request_id`), a backward-compatibility fallback module (`_compat.py`) was introduced in generated client packages to maintain compatibility with older versions of `google-api-core`.

Once `google-api-core >= 2.26.0` (or the version containing `setup_request_id`) becomes the minimum required version across all generated client packages, this fallback can be removed.

## Tasks

- [ ] Remove `_compat.py.j2` template from `gapic-generator-python`.
- [ ] Update `client.py.j2` and `async_client.py.j2` to import `setup_request_id` directly from `google.api_core.gapic_v1.requests`.
- [ ] Remove `_compat.py` files from `tests/integration/goldens/`.

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。