googleapis / googleapis/google-cloud-python

[async REST] Remove guards for async rest transport and async client generation once async REST support is GA

Aperta
#16,286 3 commenti 0 reazioni 0 assegnatari Vedi su GitHub
priority: p2 type: feature request
Lingua principale
Python
Stelle
5.4k
Fork
1.8k
Merge medio
3g 4h
PR unite (30g)
122

Descrizione

Once support for async `REST` transport goes from `experimental` -> `GA`,
we need to remove the following conditions that guard the generation of the async rest transport and the async client:

from `rest_asyncio.py.j2`:
```
{% set rest_async_io_enabled = api.all_library_settings[api.naming.proto_package].python_settings.experimental_features.rest_async_io_enabled %}
{% if rest_async_io_enabled %}
..code
{% endif %}{# if rest_async_io_enabled #}
```

from `async_client.py.j2`:
```
{% set rest_async_io_enabled = api.all_library_settings[api.naming.proto_package].python_settings.experimental_features.rest_async_io_enabled %}
{% set is_grpc_transport = True if 'grpc' in opts.transport else False %}
{% if rest_async_io_enabled or is_grpc_transport %}
..code
{% endif %}{# if rest_async_io_enabled and is_grpc_transport #}
```
Making this change wil generate the relevant files i.e `rest_asyncio.py` and `async_client.py` unconditionally for GAPICs.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.