googleapis / googleapis/google-cloud-python
Check coverage across python runtimes
Offen
#16,211
1 Kommentar
0 Reaktionen
1 zugewiesene Person
Beansprucht von @chalmerlowe
Auf GitHub ansehen
priority: p3
type: cleanup
- Vorherrschende Sprache
- Python
- Sterne
- 5.4k
- Forks
- 1.8k
- Ø Merge
- 3 T. 4 Std.
- Gemergte PRs (30 T.)
- 122
Beschreibung
Recently, we have been adding conditionals that perform different logic depending on the python version or dependency versions (https://github.com/googleapis/gapic-generator-python/pull/2477, https://github.com/googleapis/gapic-generator-python/pull/2472)
Individual coverage checks aren't aware of the big picture, so individual runs often fail the coverage check, unless we add `pragma: no cover` statements
We should find a way to fix this at some point, to make sure we don't make a habit of adding `no cover` and losing required coverage
Beitragsleitfaden
Bewertung
Dieses Issue wurde noch nicht bewertet.