googleapis / googleapis/google-cloud-python
Missing retry during ExecuteStreamingSql call in _restart_on_unavailable
- Lenguaje dominante
- Python
- Estrellas
- 5.4k
- Forks
- 1.8k
- Merge medio
- 3 d 4 h
- PR fusionados (30 d)
- 122
Descripción
The [_restart_on_unavailable](https://github.com/googleapis/python-spanner/blob/cb74679a05960293dd03eb6b74bff0f68a46395c/google/cloud/spanner_v1/snapshot.py#L51C5-L51C28) method restarts an iteration in case of an `UNAVAILABLE` error. However, the [initial RPC](https://github.com/googleapis/python-spanner/blob/cb74679a05960293dd03eb6b74bff0f68a46395c/google/cloud/spanner_v1/snapshot.py#L88) call for ExecuteStreamingSql/ExecuteStreamingRead to get the iterator may also fail with an `UNAVAILABLE` error, and this retry is not handled. Consequently, errors are surfaced to the customer where the intended behavior is to retry the requests.
One example of this issue is https://github.com/googleapis/python-spanner/issues/1150
Guía de contribución
Evaluación
Este issue todavía no se ha evaluado.