googleapis / googleapis/google-cloud-python
Model doesn't call `super.__init_`
Open
api: datastore
api: ndb
priority: p3
type: bug
- Dominant language
- Python
- Stars
- 5.4k
- Forks
- 1.8k
- Avg merge
- 3d 4h
- Merged PRs (30d)
- 122
Description
Hi all! Is there a reason that `Model.__init__` doesn't call `super().__init__`? I get that it takes all of the kwargs, but not calling `super().__init__` at all breaks multiple inheritance. Eg instantiating this class will never call `Other.__init__`:
```py
class Foo(ndb.Model, Other):
pass
```
If I add `super().__init__()` at the top of `Model.__init__`, that fixes this, and `Other.__init__` gets called correctly.
I can work around this by always putting other classes before `ndb.Model` in the inheritance list, but that's brittle and error-prone, and not documented.
Thanks in advance!
Contributor guide
Assessment
This issue has not been assessed yet.