googleapis / googleapis/google-cloud-python

Support AsyncBulkWriter

Aperta
#15,370 1 commento 0 reazioni 1 assegnatario Assegnata a @daniel-sanche Vedi su GitHub
api: firestore priority: p3 type: feature request
Lingua principale
Python
Stelle
5.4k
Fork
1.8k
Merge medio
3g 4h
PR unite (30g)
122

Descrizione

While the current implementation of BulkWriter offers performance gains over batch writes, it has the following comment:

```
The submission of batches is internally parallelized with a ThreadPoolExecutor,
meaning end developers do not need to manage an event loop or worry about asyncio
to see parallelization speed ups (which can easily 10x throughput). Because
of this, there is no companion `AsyncBulkWriter` class, as is usually seen
with other utility classes.
```

In fact, the flush method uses time.sleep, which is explicitly blocking. It would be great to have an actual async bulk writer as the current version is not useful in truly async codebases.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.