googleapis / googleapis/google-cloud-python
run system tests against enterprise databases
Offen
#15,369
1 Kommentar
0 Reaktionen
1 zugewiesene Person
Zugewiesen an @daniel-sanche
Auf GitHub ansehen
api: firestore
priority: p3
type: cleanup
- Vorherrschende Sprache
- Python
- Sterne
- 5.4k
- Forks
- 1.8k
- Ø Merge
- 3 T. 4 Std.
- Gemergte PRs (30 T.)
- 122
Beschreibung
In https://github.com/googleapis/python-firestore/pull/1047, we added a verify_pipeline step to the system tests, allowing us to run queries using the RunQuery rpc, and a Pipelines query, and compare results.
But RunQuery calls are not supported in the enterprise mode private preview, so enterprise databases aren't used for tests currently. When enterprise databases are GA, it should be added to the [TEST_DATABASES list](https://github.com/googleapis/python-firestore/blob/b2546f783b94d2cf20e46bd4ff044edd1d27aacf/tests/system/test__helpers.py#L22) (possibly replacing FIRESTORE_NAMED_DB, if they are interchangeable)
Beitragsleitfaden
Bewertung
Dieses Issue wurde noch nicht bewertet.