googleapis / googleapis/google-cloud-python

change table to target in mutations batcher

Aperta
#15,301 1 commento 0 reazioni 1 assegnatario Rivendicata da @daniel-sanche Vedi su GitHub
api: bigtable priority: p3 type: cleanup
Lingua principale
Python
Stelle
5.4k
Fork
1.8k
Merge medio
3g 4h
PR unite (30g)
122

Descrizione

The mutation batcher's [first argument is called table](https://github.com/googleapis/python-bigtable/blob/97a019833d82e617769c56761aa5548d3ab896b9/google/cloud/bigtable/data/_async/mutations_batcher.py#L215). Going forward, it should be target, since it can be a table or authorized view

In practice, this change shouldn't break much, since it's typically either constructed using `table.mutations_batcher()`, or `MutationsBatcher(table)`. But it would break users who create a batcher using `MutationsBatcher(table=table)`. So for backwards compatibility reasons, we should ony change this when we're ready for a major version bump

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.