googleapis / googleapis/google-cloud-python

change table to target in mutations batcher

Open
#15,301 1 comment 0 reactions 1 assignee Claimed by @daniel-sanche View on GitHub
api: bigtable priority: p3 type: cleanup
Dominant language
Python
Stars
5.4k
Forks
1.8k
Avg merge
3d 4h
Merged PRs (30d)
122

Description

The mutation batcher's [first argument is called table](https://github.com/googleapis/python-bigtable/blob/97a019833d82e617769c56761aa5548d3ab896b9/google/cloud/bigtable/data/_async/mutations_batcher.py#L215). Going forward, it should be target, since it can be a table or authorized view

In practice, this change shouldn't break much, since it's typically either constructed using `table.mutations_batcher()`, or `MutationsBatcher(table)`. But it would break users who create a batcher using `MutationsBatcher(table=table)`. So for backwards compatibility reasons, we should ony change this when we're ready for a major version bump

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.