googleapis / googleapis/google-cloud-python

async AuthorizedSession refresh should support async credential refresh method

Aberta
#15,211 4 comentários 2 reações 1 responsável Reivindicada por @arithmetic1728 Ver no GitHub
priority: p3 type: bug
Linguagem predominante
Python
Estrelas
5.4k
Forks
1.8k
Merge médio
2d 23h
PRs com merge (30d)
123

Descrição

Recently I migrated from my custom async implementation to the beta implementation however I noticed two issues:

1) _CombinedResponse is missing the reason property and occasionally errors out, my fix:
```python
class _CombinedResponse(_GoogleCombinedResponse):
@property
def reason(self):
return self._response.reason
```
2) the credentials refresh does not support an async call (which should be the default if you're using the credentials_async class

fix is making this call async: https://github.com/googleapis/google-auth-library-python/blob/main/google/auth/transport/_aiohttp_requests.py#L371

if sync needs to be supported it should do a check if the method is awaitable/a coroutine or not.

#### Environment details

- OS: OSX
- Python version: 3.8
- pip version:
- `google-auth` version: 2.2.1

#### Steps to reproduce

1. auth error during googleapiclient call

Guia de contribuição

Abrir o guia de contribuição

Avaliação

Esta issue ainda não foi avaliada.

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.