googleapis / googleapis/google-cloud-python

BidiRpc missing timeout and retry arguments

Ouverte
#15,084 2 commentaires 0 réactions 1 personne assignée Réclamée par @tswast Voir sur GitHub
type: feature request
Langage dominant
Python
Étoiles
5.4k
Forks
1.8k
Merge moyen
3 j 4 h
PR mergées (30 j)
122

Description

**Is your feature request related to a problem? Please describe.**

Most (all?) generated methods contain the following arguments:

```
retry: google.api_core.retry.Retry = google.api_core.gapic_v1.method.DEFAULT,
timeout: float = None,
metadata: Sequence[Tuple[str, str]] = (),
```

I'd like to be able to pass these through from the method I'm wrapping. Currently, this is possible with `metadata`. See:

https://github.com/googleapis/python-api-core/blob/40f52bf1100cf56b7f9af267d210b8a72fc34f08/google/api_core/bidi.py#L279

But it does not appear to be possible with other arguments such as `timeout` and `retry`.

**Describe the solution you'd like**

Add `retry` and `timeout` as optional arguments to `BidiRpc`.

Perhaps if `retry` and `timeout` aren't available in older generated clients, some additional logic will be required to prevent breaking them? I recall they've been around for quite some time, though.

**Describe alternatives you've considered**

Perhaps an arbitrary `**kwargs` dictionary for extra arguments to pass to the `_start_rpc` method?

**Additional context**

* https://github.com/googleapis/python-bigquery-storage/pull/278
* https://github.com/googleapis/google-cloud-python/issues/16450 -- I suspect this feature will need to be implemented before the generator can consider using BidiRpc by default.

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.