googleapis / googleapis/google-cloud-python

Add wrap logic directly to the property methods for callables for long running operations

Abierto
#15,037 2 comentarios 0 reacciones 1 asignado Reclamado por @ohmayr Ver en GitHub
priority: p3 type: feature request
Lenguaje dominante
Python
Estrellas
5.4k
Forks
1.8k
Merge medio
3 d 4 h
PR fusionados (30 d)
122

Descripción

Instead of implementing `_prep_wrapped_messages` in the base class and overriding it in the async classes, we should wrap the logic directly within the property callable methods and get rid of this method (both from the base class and the subclasses).

What we have now:

```python3
@property
def get_operation(
self,
) -> Callable[
[operations_pb2.GetOperationRequest],
Coroutine[Any, Any, operations_pb2.Operation],
]:
return self._get_operation
```

Instead we could do something like:
```python3
@property
def get_operation(
self,
) -> Callable[
[operations_pb2.GetOperationRequest],
Coroutine[Any, Any, operations_pb2.Operation],
]:
return gapic_v1.method_async.wrap_method(
self.list_operations,
default_retry=retries_async.AsyncRetry(
initial=0.5,
maximum=10.0,
multiplier=2.0,
predicate=retries_async.if_exception_type(
core_exceptions.ServiceUnavailable,
),
deadline=10.0,
),
default_timeout=10.0,
client_info=self.client_info,
),
```

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.