googleapis / googleapis/google-cloud-node

Stream retries

Aperta
#7,802 8 commenti 0 reazioni 2 assegnatari Assegnata a @leahecole Vedi su GitHub
library: google-cloud-node-core type: feature request
Lingua principale
TypeScript
Stelle
3.2k
Fork
712
Merge medio
2g 9h
PR unite (30g)
104

Descrizione

The NodeJS Firestore SDK currently has some logic that tries to detect whether a stream is healthy. If an error occurs before a stream has received a response message, the Firestore SDK retries its idempotent streams transparently.

I would like to explore the option of adding this retry behavior directly to GAX, which would allow us to simplify the Firestore SDK, increase the reliability for all other NodeJS SDKs and expose the same backoff behavior for all request types.

For reference, the Firestore implementation lives here: https://github.com/googleapis/nodejs-firestore/blob/master/dev/src/index.ts#L1170

A general retry mechanism for unary streams has recently been added to Python's GAX: https://github.com/googleapis/google-cloud-python/pull/10206

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.