googleapis / googleapis/google-cloud-node

Stream retries

Open
#7,802 8 comments 0 reactions 2 assignees Assigned to @leahecole View on GitHub
library: google-cloud-node-core type: feature request
Dominant language
TypeScript
Stars
3.2k
Forks
712
Avg merge
2d 3h
Merged PRs (30d)
99

Description

The NodeJS Firestore SDK currently has some logic that tries to detect whether a stream is healthy. If an error occurs before a stream has received a response message, the Firestore SDK retries its idempotent streams transparently.

I would like to explore the option of adding this retry behavior directly to GAX, which would allow us to simplify the Firestore SDK, increase the reliability for all other NodeJS SDKs and expose the same backoff behavior for all request types.

For reference, the Firestore implementation lives here: https://github.com/googleapis/nodejs-firestore/blob/master/dev/src/index.ts#L1170

A general retry mechanism for unary streams has recently been added to Python's GAX: https://github.com/googleapis/google-cloud-python/pull/10206

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.