googleapis / googleapis/google-cloud-node

Selective gapic generation is broken

Aperta
#7,672 8 commenti 1 reazione 1 assegnatario Vedi su GitHub

@kevkim-codes ci sta già lavorando.

Dal 13/8/2025.

library: google-cloud-node-core priority: p2 size: s type: bug
Lingua principale
TypeScript
Stelle
3.2k
Fork
713
Merge medio
2g 9h
PR unite (30g)
104

Descrizione

I think the selective gapic generation isn't quite working, and in order to confirm we should add a full test that reads from an actual service config file, like this in this PR. @danieljbruce and I were trying out selective gapic with bigtable admin, and we attempted to generate a new library with this file. The outcome of the generation was that only a single method was listed internal, RestoreTableMetadata. This seems wrong since we listed a bunch of methods to be internal, but I also am not very familiar with the logic behind what gets generated or not.

Also, we had to change the settings property from node_settings to typescript_settings to get anything to produce, which is not how the service_yaml file is set up (it should be node_settings). I think this is a bug in the generator implementation.

Guida per i contributori

Apri la guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.