googleapis / googleapis/google-cloud-java

[java-shared-config] Ignore provided scoped dependencies from maven-dependency-plugin

未关闭
#13,743 3 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
priority: p3 type: cleanup
主要语言
Java
星标
2.1k
派生
1.2k
平均合并
1 天 23 小时
30 天内合并 PR
154

描述

This came up in an offline discussion with @burkedavison as part of https://github.com/googleapis/java-shared-config/pull/815.

The `downstream / dependencies (11, java-spanner)` in the PR was failing with the following error:

```
[INFO] --- maven-dependency-plugin:3.5.0:analyze (default-cli) @ google-cloud-spanner ---
Error: Used undeclared dependencies found:
Error: org.graalvm.sdk:nativeimage:jar:24.0.1:provided
```
However, this dependency is intentionally scoped as `provided` making this failure a false positive.

Potential Solution: Set the maven-dependency-plugin's `ignoreNonCompile` parameter to `true` (https://maven.apache.org/plugins/maven-dependency-plugin/analyze-mojo.html#ignoreNonCompile) to ignore `provided` scoped dependencies when `mvn dependency:analyze` is called. The configuration change will likely be at:

https://github.com/googleapis/java-shared-config/blob/3c3c6307ea88dc56f5901a95c295d1b2d53a3559/java-shared-config/pom.xml#L144-L158

cc/ @suztomo

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。