googleapis / googleapis/google-cloud-java

[java-firestore] `ServerSideTransaction.execute` ignores `PipelineExecuteOptions` argument

Open
#13,094 0 comments 0 reactions 1 assignee Claimed by @MarkDuckworth View on GitHub
api: firestore
Dominant language
Java
Stars
2.1k
Forks
1.2k
Avg merge
1d 23h
Merged PRs (30d)
154

Description

**Description:**

When executing a pipeline within a transaction, the `ServerSideTransaction.execute` method that accepts a `PipelineExecuteOptions` parameter completely ignores it and instantiates an empty options object instead.

**Steps to Reproduce / Code Snippet:**
In `google-cloud-firestore/src/main/java/com/google/cloud/firestore/ServerSideTransaction.java`:

```java
@Nonnull
@Override
public ApiFuture execute(
@Nonnull Pipeline pipeline, @Nonnull PipelineExecuteOptions options) {
try (TraceUtil.Scope ignored = transactionTraceContext.makeCurrent()) {
// BUG: ignores the 'options' parameter entirely
return pipeline.execute(new PipelineExecuteOptions(), transactionId, null);
}
}
```

Because of this, any custom options explicitly provided during `transaction.execute(pipeline, options)` get dropped before the underlying gRPC `ExecutePipelineRequest` is dispatched.

**Expected Behavior:**
The method should propagate the correctly populated `options` object provided in the method signature:

```java
@Nonnull
@Override
public ApiFuture execute(
@Nonnull Pipeline pipeline, @Nonnull PipelineExecuteOptions options) {
try (TraceUtil.Scope ignored = transactionTraceContext.makeCurrent()) {
return pipeline.execute(options, transactionId, null);
}
}
```

**Impact:**
Integration tests like `ITPipelineTest.testPipelineInTransactionsWithOptions` end up inadvertently testing with empty options because instances like `new PipelineExecuteOptions().with("foo", "bar")` are discarded silently.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.