googleapis / googleapis/google-cloud-java

[java-pubsub] Publisher does not automatically propagate otel baggage information when publishing event

Aperta
#13,048 1 commento 0 reazioni 1 assegnatario Rivendicata da @michaelpri10 Vedi su GitHub
api: pubsub type: feature request
Lingua principale
Java
Stelle
2.1k
Fork
1.2k
Merge medio
1g 23h
PR unite (30g)
154

Descrizione

**Is your feature request related to a problem? Please describe.**
In version 1.133.0, java pubsub client already use OpenTelemetry. But after testing it, it does not automatically propagate `baggage` information. It only propagates `traceparent` information.

**Describe the solution you'd like**
Automatically propagate baggage information.

**Describe alternatives you've considered**
Automatically propagate context using registered propagators in open telemetry.

**Additional context**
Similar to how kafka auto instrumentation works, they use `openTelemetry.getPropagators().getTextMapPropagator()` to get the propagators and inject it using `propagator().inject(context, record.headers(), SETTER);`.
https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/e2dd703a8a0d47ed12d3beca79dc9740822da4f1/instrumentation/kafka/kafka-clients/kafka-clients-2.6/library/src/main/java/io/opentelemetry/instrumentation/kafkaclients/v2_6/KafkaTelemetry.java#L226

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.