googleapis / googleapis/google-cloud-java

[google-auth-library-java] Add support for JCA Provider to ServiceAccountCredentials

Aperta
#12,613 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
type: feature request
Lingua principale
Java
Stelle
2.1k
Fork
1.2k
Merge medio
1g 23h
PR unite (30g)
154

Descrizione

The current API for ServiceAccountCredentials does not support explicitly setting a Provider. (This is true for all Credentials implementing ServiceAccountSigner, but changing it consistently for all these should also incorporate changes to com.google.api.client.json.webtoken.JsonWebSignature in my opinion).

The current behaviour relies on JCA to always yield the correct provider for java.security.Signature regardless of how the key is stored. When the key is stored in a KeyVault or on a HSM this assumption fails. This is a design limitation in the JCA and requires the use of explicit providers.

I have a patch that fixes the issue for ServiceAccountCredentials, and suggest that similar work is done on the other GoogleCredentials implementations.

#### Environment details

- OS: All
- Java version: 1+
- google-auth-library-java version(s): All versions before 0a57cd56cca2af41e8e4645302ca602aab10be4e

#### Steps to reproduce

1. Add another JCA provider providing the "RSAwithSHA256" signature algorithm to the stack bottom of the stack.
2. Create an opaque private key.
3. Use this key for signing the authentication assertions.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.