googleapis / googleapis/google-cloud-java

[google-auth-library-java] Generating ID token with ImpersonatedCredentials does not support overriding quota project

Aperta
#12,604 2 commenti 0 reazioni 1 assegnatario Assegnata a @TimurSadykov Vedi su GitHub
help wanted priority: p3 type: feature request
Lingua principale
Java
Stelle
2.1k
Fork
1.2k
Merge medio
1g 23h
PR unite (30g)
154

Descrizione

**Is your feature request related to a problem? Please describe.**
`ImpersonatedCredentials` accepts a quota project in its builder, and the quota project is properly overridden when generating an access token. However, when generating id token with the `idTokenWithAudience()` method, it won't perform such override. The impact is that if a service does impersonate many IdTokens on its own quota - it exceeds a default limit of 60k.

**Describe the solution you'd like**
It seems to me that providing the quota project in the `additionalFields` argument when invoking the `IamUtils.getIdToken()` method would work

**Describe alternatives you've considered**
There doesn't seem to be good alternatives.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.