googleapis / googleapis/google-cloud-java
[sdk-platform-java] Bring google-java-format to 1.14 that requires JDK 11
- Langage dominant
- Java
- Étoiles
- 2.1k
- Forks
- 1.2k
- Merge moyen
- 1 j 23 h
- PR mergées (30 j)
- 154
Description
Recording my observation of RenovateBot failure on google-java-format.
#### Environment details
- Programming language: Java
- OS: N/A
- Language runtime version: N/A
- Package version: N/A
#### Steps to reproduce
1. Try bringing up google-java-format version to the latest (1.14), the build fails: https://github.com/googleapis/gapic-generator-java/pull/945
2. Read the error message
```
[INFO] -------------------------------------------------------------
Error: COMPILATION ERROR :
[INFO] -------------------------------------------------------------
Error: /home/runner/work/gapic-generator-java/gapic-generator-java/src/main/java/com/google/api/generator/engine/writer/JavaFormatter.java:[18,40] cannot access com.google.googlejavaformat.java.Formatter
bad class file: /home/runner/.m2/repository/com/google/googlejavaformat/google-java-format/1.14.0/google-java-format-1.14.0.jar(com/google/googlejavaformat/java/Formatter.class)
class file has wrong version 55.0, should be 52.0
Please remove or make sure it appears in the correct subdirectory of the classpath.
```
Interestingly, it's a compilation error probably because how Bazel uses google-java-format.
Since 1.8, google-java-format requires JDK 11.
> The minimum supported runtime version is now JDK 11.
https://github.com/google/google-java-format/releases/tag/google-java-format-1.8
Guide de contribution
Ouvrir le guide de contribution
Évaluation
Cette issue n'a pas encore été évaluée.