googleapis / googleapis/google-cloud-java

[sdk-platform-java] Investigate InstantiatingGrpcChannelProvider's `isOnComputeEngine()` invocation on every channel creation

Abierto
#12,430 0 comentarios 0 reacciones 0 asignados Ver en GitHub
priority: p2 type: feature request
Lenguaje dominante
Java
Estrellas
2.1k
Forks
1.2k
Merge medio
1 d 23 h
PR fusionados (30 d)
154

Descripción

When a gRPC channel is created, the logic will invoke the `canUseDirectPath()` method: https://github.com/googleapis/sdk-platform-java/blob/af10a9ef26a5fd9f24fc5341d144b8ee00ff3d00/gax-java/gax-grpc/src/main/java/com/google/api/gax/grpc/InstantiatingGrpcChannelProvider.java#L476-L48. This call has a check to `isOnComputeEngine()` which will read a system file for GCE properties.

We may be able to improve performance a bit as we may only need to read this file once. It may be even more performant for ChannelPools which constantly resize the channels as it'll repeatedly create new channels (and read a file every time).

Consider making the `isOnComputeEngine()` call non-static and introduce a way to cache the systemProduceName value once it's read the first time. Subsequent calls will not need to read the file and can simply return the cached value.

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.