googleapis / googleapis/google-cloud-java

[sdk-platform-java] Generator is not generating all the root level resources in the proto files

Open
#12,402 1 comment 0 reactions 0 assignees View on GitHub
priority: p3 type: bug
Dominant language
Java
Stars
2.1k
Forks
1.2k
Avg merge
1d 23h
Merged PRs (30d)
154

Description

See [this](yaqs/4937742893109477376#n15) and the earlier comments in the thread for more context.

Given two top level resources added to the proto file:
```
option (google.api.resource_definition) = {
type: "service.googleapis.com/FolderLocation"
pattern: "folders/{folder}/locations/{location}"
};

option (google.api.resource_definition) = {
type: "service.googleapis.com/OrganizationLocation"
pattern: "organizations/{organization}/locations/{location}"
};
```
It seems to only generate a resource for FolderLocation as `FolderLocationName`.

These resource definitions are the parent to a child resource:
```
message ChildResource {
option (google.api.resource) = {
type: "service.googleapis.com/ChildResource"
pattern: "organizations/{organization}/locations/{location}/things/{thing}"
pattern: "folders/{folder}/locations/{location}/things/{thing}"
plural: "childResource"
singular: "childResource"
};
}
```

These should map properly to the the two top level resource definitions, but it only seems to map to one.

We need to investigate why only one of these resources is being created.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.