googleapis / googleapis/google-cloud-java
[java-spanner] Extend Spanner client metrics
- Langage dominant
- Java
- Étoiles
- 2.1k
- Forks
- 1.2k
- Merge moyen
- 1 j 23 h
- PR mergées (30 j)
- 154
Description
**Is your feature request related to a problem? Please describe.**
We would like to receive more client metrics for spanner clients. Usually information like:
- retries
- latencies
- requests per second
allows to trace down issues by service-instance that uses spanner. There are server-side metrics that can not provide the same insights as metrics independent of a deployed service.
**Describe the solution you'd like**
Right now, open census metrics are used to provide information about:
- oc_worker_spans
- sessions
It would be awesome if this list can be extended by
- retries
- latencies
- requests per second.
Right now, we use the Prometheus open census exporter to export the metrics that we can expose via Prometheus. In an ideal scenario, metrics would also be exposed using micrometer because it's part of the popular spring boot stack.
**Describe alternatives you've considered**
- building our custom metrics (Gauges, counters) for each service (already done in other teams, but this is a lot of work)
- building our own abstraction layer that would allow us to build a reusable spanner client that exposes metrics that can be reused
- not to do it and only rely on server metrics in combination with high-level client metrics like HTTP request latencies
Thanks in advance and keep up the good work!
Guide de contribution
Ouvrir le guide de contribution
Évaluation
Cette issue n'a pas encore été évaluée.