googleapis / googleapis/google-cloud-java

[java-bigquery] Update documentation for job.waitFor

未关闭
#12,173 2 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
api: bigquery priority: p3
主要语言
Java
星标
2.1k
派生
1.2k
平均合并
1 天 23 小时
30 天内合并 PR
157

描述

After [this commit](https://github.com/googleapis/java-bigquery/commit/2a0d86d2d07dd706fb7d943da6ebd5c9ac98dfca#diff-0a2f4a883a695233b6d143e64bb0b868d511d1c917f1a081281a9b16fd061c28 ) com.google.cloud.bigquery.Job.waitFor behavior changed significantly.
It starts to throws JobException/BigQueryException when there is any execution error in Job in reload method

However in many javadoc places and example code, following workflow is suggested, which does won't work anymore because BigQueryException is now being thrown in reload()
```
Job completedJob = job.waitFor();
if (completedJob == null) {
// job no longer exists
} else if (completedJob.getStatus().getError() != null) {
// job failed, handle error
} else {
// job completed successfully
}
```
Also method header

> public Job reload(JobOption... options)

and

> public Job waitFor(RetryOption... waitOptions) throws InterruptedException

should contain

> throws BigQueryException

I was much happier with previous way of dealing with job execution errors, but I assume it is too late to revert it back, so at least documentation should be right

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。