googleapis / googleapis/google-cloud-java

java-datastore: LocalDatastoreHelper is downloading datastore emulator zip every time even when file exists

未关闭 适合新手
#12,058 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
api: datastore priority: p3 type: bug
主要语言
Java
星标
2.1k
派生
1.2k
平均合并
1 天 23 小时
30 天内合并 PR
157

描述

When the [LocalDatastoreHelper](https://github.com/googleapis/google-cloud-java/blob/main/java-datastore/google-cloud-datastore/src/main/java/com/google/cloud/datastore/testing/LocalDatastoreHelper.java) is started with `.start()` API it is downloading a 36mb zip file from `http://storage.googleapis.com/gcd/tools/cloud-datastore-emulator-2.3.1.zip` every time even if file already exist locally.

This is due to checksum mismatch at:

https://github.com/googleapis/sdk-platform-java/blob/56aa3438393e1992bb8f688291fb12030ec9bc0e/java-core/google-cloud-core/src/main/java/com/google/cloud/testing/BaseEmulatorHelper.java#L465-L479

The checksum value that LocalDatastoreHelper is passing down is not correct:

https://github.com/googleapis/google-cloud-java/blob/aa2c24982903071ab0408fac4357fb8dd067a3fa/java-datastore/google-cloud-datastore/src/main/java/com/google/cloud/datastore/testing/LocalDatastoreHelper.java#L68

The actual file checksum is `7c1f5a3276241a8f78cb1a837daaaa47`:

```
> curl http://storage.googleapis.com/gcd/tools/cloud-datastore-emulator-2.3.1.
zip | md5sum
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 36.1M 100 36.1M 0 0 8831k 0 0:00:04 0:00:04 --:--:-- 8833k
7c1f5a3276241a8f78cb1a837daaaa47 -
```

贡献指南

打开贡献指南

调研方向

从 java-datastore/google-cloud-datastore/src/main/java/com/google/cloud/datastore/testing/LocalDatastoreHelper.java 开始,然后将传递给 BaseEmulatorHelper.java 的校验和与文档中记录的 MD5 进行比较。当校验和与 7c1f5a3276241a8f78cb1a837daaaa47 匹配,并且现有的 emulator zip 不会再次下载时,即表示完成。

由索引模型根据 Issue 内容生成。

评估

技术栈
java
领域
databases
Issue 类型
缺陷
难度
1/5
预计耗时
1 小时以内
活跃度
冷清
描述清晰度
描述清楚
新手友好度
65/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。