googleapis / googleapis/google-cloud-java

[java-bigquerystorage] Possibly excessive logging for successful stream operations

Offen
#12,040 1 Kommentar 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
priority: p2 type: cleanup type: feature request
Vorherrschende Sprache
Java
Sterne
2.1k
Forks
1.2k
Ø Merge
1 T. 23 Std.
Gemergte PRs (30 T.)
157

Beschreibung

When using bigquerystorage stream writer api, each write requests creates a new `WriterStream` object.

A successful write operation ends with an [RuntimeException](https://github.com/googleapis/google-cloud-java/blob/9f72a6410c1e596dde4d4c7aa5365e1e277b0114/java-bigquerystorage/google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/StreamConnection.java#L94) which is handled by the [StreamWorker](https://github.com/googleapis/google-cloud-java/blob/9f72a6410c1e596dde4d4c7aa5365e1e277b0114/java-bigquerystorage/google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/ConnectionWorker.java#L1391).

Stream worker is printing the "successful error" log messages at an INFO level. Additionally, during product development more log messages in the Stream Worker were moved from `FINE` level into `INFO` level: [PR 1999](https://github.com/googleapis/java-bigquerystorage/pull/1999/changes) and [PR 2017](https://github.com/googleapis/java-bigquerystorage/pull/2017/changes).

As a result of this, every successful write stream now prints quite a lot of what I consider to be non-info level stuff cluttering the logs.

Image

If the maintainers agree that this could be improved, I am willing to contribute updating the log levels as this looks to be a "good first issue" type of problem.

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.