googleapis / googleapis/google-cloud-java

[java-datastore] Make `fromPb` constructors public

Aperta
#11,998 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
api: datastore type: feature request
Lingua principale
Java
Stelle
2.1k
Fork
1.2k
Merge medio
1g 23h
PR unite (30g)
154

Descrizione

**Is your feature request related to a problem? Please describe.**
I often run across situations where I have either a `com.google.datastore.v1.Key` or `com.google.datastore.v1.Entity` and would like to transform it into a `com.google.cloud.datastore.[Key|Entity]`. There currently exists `fromPb` constructors within this codebase, but they are not accessible outside of the `com.google.datastore` namespace.

**Describe the solution you'd like**
Making the `public`.

**Describe alternatives you've considered**
I currently have two interop packages of my own living in `com.google.datastore` that re-export these methods. It works but isn't great.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.