googleapis / googleapis/google-cloud-cpp

Find a better way to dedup bigtable map proto key value pairs

Open
#15,766 0 comments 0 reactions 0 assignees View on GitHub
type: cleanup
Dominant language
C++
Stars
659
Forks
462
Avg merge
1d 2h
Merged PRs (30d)
89

Description

Currently using the serialized string of the key proto. Since we're comparing fields of a message and not between different messages and we know they will always be serialized with the same version of protobuf, it lessens the likelihood of incorrect results. It would be better to find an officially "blessed" method of doing this.

Contributor guide

Open the contributing guide

Research direction

Start by locating the Bigtable map proto key-value deduplication code and the current use of serialized key-proto strings. Investigate an officially supported protobuf comparison or equality method for fields within the same message type. Done means the deduplication approach is agreed upon and no longer relies on serialized strings.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, google-cloud
Domain
databases
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.