googleapis / googleapis/google-cloud-cpp
Investigate Redundant `@com_google_benchmark//:benchmark` Dependency in Bazel Builds
- 主要语言
- C++
- 星标
- 659
- 派生
- 462
- 平均合并
- 1 天 2 小时
- 30 天内合并 PR
- 89
描述
Pull request #15543 fixed build failures in several benchmark targets on the macOS Bazel CI. The builds were failing because they were missing a direct dependency on `@com_google_benchmark//:benchmark`, even though they already depended on `@com_google_benchmark//:benchmark_main`.
While adding the explicit dependency resolves the build errors, it's not clear why this is necessary. According to the `google/benchmark` [BUILD.bazel file](https://github.com/google/benchmark/blob/d65c35c406858939084ef96c72663ec382f75d37/BUILD.bazel#L95), the `:benchmark_main` target depends on `:benchmark` and should export the necessary headers and symbols.
This issue affects the macOS Bazel CI builds.
This issue is to track the investigation into the root cause of this behavior:
1. Why is a direct dependency on `@com_google_benchmark//:benchmark` required when a dependency on `@com_google_benchmark//:benchmark_main` already exists?
2. Why does this issue appear to be specific to the macOS Bazel CI build environment?
3. Is there a more fundamental issue in how dependencies are being resolved or in the toolchain configuration?
**Acceptance Criteria:**
* Understand and document the reason for the seemingly redundant dependency.
* Determine if a configuration change can remove the need for the explicit dependency on `@com_google_benchmark//:benchmark` in the benchmark targets.
**Reference:**
* PR #15543: fix(bazel): Add missing dependency to benchmark targets
贡献指南
调研方向
从 PR #15543 以及 macOS Bazel CI 构建中受影响的 benchmark 目标开始。将它们的依赖声明与 google/benchmark 引用的 BUILD.bazel 文件进行比较,并调查 macOS 工具链如何解析 benchmark 和 benchmark_main。完成的标准是记录原因,并确定配置更改是否可以移除显式依赖。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- cpp
- 领域
- build-system, ci-cd
- Issue 类型
- 缺陷
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 活跃度
- 停滞
- 描述清晰度
- 基本清楚
- 新手友好度
- 35/100