googleapis / googleapis/google-cloud-cpp
Refactor how DefaultRowReader determines when to call OperationContext::PostCall
- Dominant language
- C++
- Stars
- 659
- Forks
- 462
- Avg merge
- 1d 2h
- Merged PRs (30d)
- 89
Description
It would be nice to remove the recently added `bool called_post_call_;` member variable and instead refactor how the internal state machine works to ensure OperationContext::PostCall is only called once regardless of success, error, or cancellation.
Contributor guide
Research direction
Locate DefaultRowReader and inspect how its called_post_call_ member coordinates OperationContext::PostCall. Trace the success, error, and cancellation state transitions before deciding how they can guarantee a single PostCall invocation without that member. Done means all three paths call PostCall exactly once, but the issue names no files or tests to run.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100