googleapis / googleapis/google-cloud-cpp

Refactor how DefaultRowReader determines when to call OperationContext::PostCall

Open
#15,314 0 comments 0 reactions 0 assignees View on GitHub
type: cleanup
Dominant language
C++
Stars
659
Forks
462
Avg merge
1d 2h
Merged PRs (30d)
89

Description

It would be nice to remove the recently added `bool called_post_call_;` member variable and instead refactor how the internal state machine works to ensure OperationContext::PostCall is only called once regardless of success, error, or cancellation.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.