googleapis / googleapis/google-cloud-cpp
Generalize `RowKeyType::clear()`
Aperta
api: bigtable
type: cleanup
- Lingua principale
- C++
- Stelle
- 659
- Fork
- 462
- Merge medio
- 1g 2h
- PR unite (30g)
- 89
Descrizione
`bigtable::RowKeyType` is a `std::string` in OSS-land, and an `absl::Cord` in Google-land.
`absl::Cord::clear()` is deprecated, in favor of `absl::Cord::Clear()`. `std::string::Clear()` is not a thing.
We need to add a new `Clear(RowKeyType&)` function to this file:
https://github.com/googleapis/google-cloud-cpp/blob/main/google/cloud/bigtable/internal/google_bytes_traits.h
which calls `std::string::clear()` in OSS-land, and `absl::Cord::Clear()` in Google-land.
This unblocks a LSC in Google-land.
Guida per i contributori
Apri la guida per i contributori
Valutazione
Questa issue non è ancora stata valutata.