googleapis / googleapis/google-cloud-cpp

Update Spanner Interval integration tests to call `UsingEmulator()`

Aperta
#15,162 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
api: spanner type: cleanup
Lingua principale
C++
Stelle
659
Fork
462
Merge medio
1g 2h
PR unite (30g)
89

Descrizione

The Spanner integrations tests have been written to expect particular behavior from the emulator, even it is an error, rather than just skipping the test altogether. See all the other UsingEmulator() calls in this file, for example. This allows us to learn when the emulator changes behavior and react accordingly, rather than just forgetting about the whole issue forever more.

[It also helped the emulator team, who (at least previously) ran our tests to check their implementation. Rather than just seeing successes no matter what they did, expecting the old (error) behavior allowed them to verify that things had indeed changed, and also to compare their new behavior to that of the service.]

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.