googleapis / googleapis/google-cloud-cpp

Modernize the tests for `RetryObjectReadSource`

Open
#14,426 0 comments 0 reactions 0 assignees View on GitHub
api: storage type: cleanup
Dominant language
C++
Stars
659
Forks
462
Avg merge
1d 2h
Merged PRs (30d)
89

Description

For historical reasons these tests are somewhat indirect. Fewer things could be mocked at the time. We can clean them up after the fixes for #14424

Contributor guide

Open the contributing guide

Research direction

Locate the tests for `RetryObjectReadSource` and read the fixes in issue #14424 first, since this cleanup depends on them. Compare the current indirect test setup with the newer mocking capabilities; done means the tests are less indirect while still covering the source behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
testing-qa
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.