googleapis / googleapis/google-cloud-cpp
Refactor AsyncPollingLoop to accept an Operation directly
Open
type: cleanup
- Dominant language
- C++
- Stars
- 659
- Forks
- 462
- Avg merge
- 1d 2h
- Merged PRs (30d)
- 89
Description
Currently in `AsyncAwaitLongRunningOperation` we can construct a `future>` from an `Operation` just so we can pass it to `AsyncPollingLoop`. It would be preferable to refactor `AsyncPollingLoop` such that it could accept either.
A brief attempt to do this refactoring was made, but resulted in unit test failures when trying to cancel the `future`.
Contributor guide
Assessment
This issue has not been assessed yet.