googleapis / googleapis/google-cloud-cpp
Enable checks that require code cleanup in .clang-tidy
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 659
- Forks
- 463
- Avg merge
- 1d 2h
- Merged PRs (30d)
- 89
Description
To enable it, remove it from the list of committed checks.
These checks are nice to have, but are current code does not conform to them. We need to cleanup the existing code first.
Checks to enable:
- [ ] bugprone-unused-return-value
- [ ] bugprone-inc-dec-in-condition
- [ ] bugprone-unused-local-non-trivial-variable
- [ ] misc-include-cleaner: too many *true* positives. We need to clean up the code, but we should do that over time, maybe per-directory, instead of blocking the adoption of Clang 17 until it is all fixed.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the committed-check list in .clang-tidy and the four checks named in the issue. Inspect existing violations across the codebase, clean them up incrementally, and consider directory-level progress for misc-include-cleaner; done means the listed checks can be enabled without the current code violations.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100