googleapis / googleapis/google-cloud-cpp

Enable checks that require code cleanup in .clang-tidy

Open
#14,162 0 comments 0 reactions 0 assignees View on GitHub
type: cleanup
Dominant language
C++
Stars
659
Forks
462
Avg merge
1d 2h
Merged PRs (30d)
89

Description

To enable it, remove it from the list of committed checks.

These checks are nice to have, but are current code does not conform to them. We need to cleanup the existing code first.

Checks to enable:
- [ ] bugprone-unused-return-value
- [ ] bugprone-inc-dec-in-condition
- [ ] bugprone-unused-local-non-trivial-variable
- [ ] misc-include-cleaner: too many *true* positives. We need to clean up the code, but we should do that over time, maybe per-directory, instead of blocking the adoption of Clang 17 until it is all fixed.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.