googleapis / googleapis/google-cloud-cpp

Determine best mechanism for setting service level metadata in generated libraries.

Aperta
#14,000 1 commento 0 reazioni 1 assegnatario Rivendicata da @scotthart Vedi su GitHub
cpp: generator type: cleanup
Lingua principale
C++
Stelle
659
Fork
462
Merge medio
1g 2h
PR unite (30g)
89

Descrizione

With the added support for google.api.api_version, an optional annotation, the generator needs to emit code that sets this (when specified) in the generated metadata decorator. It currently sets it as part of *Metadata::SetMetadata, but this might not be the best place. One option would be to pass this value to the metadata helper functions as another parameter, similar to `api_client_header`. another option would be to create a collection of known at compile time metadata pairs and pass that to the metadata helper function.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.