googleapis / googleapis/google-cloud-cpp
Support idempotency token for Storage client
- Lenguaje dominante
- C++
- Estrellas
- 659
- Forks
- 462
- Merge medio
- 1 d 2 h
- PR fusionados (30 d)
- 89
Descripción
The GCS API supports (or soon will support) an idempotency token header. The header allows GCS to detect if a request is a duplicate, and returns the same value for duplicate requests.
To implement this we need to:
- Create the unique id in the `RetryClient`
- The decorators below `RetryClient` need to accept a new "context" field on each function
- The gRPC and REST-based implementations need to consume this field and send it to the service as a header.
It is time to split the `RawClient` stack in two, like we do for all the other libraries. The `*Connection` stack will be used for mocks and to implement the retry loop. The typical function will look like so:
```cc
virtual StatusOr GetBucketMetadata(
GetBucketMetadataRequest const& request) = 0;
```
The `*Stub` will implement logging, tracing, and actually sending the data to the service, the typical function will look like so:
```cc
virtual StatusOr GetBucketMetadata(
rest_internal::RestContext& context,
Options const& options,
GetBucketMetadataRequest const& request) = 0;
```
Note how the options are passed explicitly and not tunneled via `CurrentOptions`. Also note that the "context" object is REST-based. We can change both over time, as the classes in the `*Stub` hierarchy are not needed for mocking.
----
Java implemented this in:
https://github.com/googleapis/java-storage/pull/2027
Internally, the design doc is [go/gcs-client-idem-token](http://goto.google.com/gcs-client-idem-token)
Guía de contribución
Línea de trabajo
Comienza siguiendo las implementaciones de RetryClient, RawClient y gRPC y REST mencionadas en la issue. Revisa cómo están separados los stacks de *Connection y *Stub, incluido el flujo de context y Options explícitas. Se considera terminado cuando el token se crea, se propaga a través de ambas implementaciones y se envía como una cabecera de servicio, preservando el comportamiento de mocking y retry.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- cpp, gcp, grpc
- Área
- api, backend-api-design, cloud
- Tipo de issue
- Nueva funcionalidad
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Estado de actividad
- Estancado
- Claridad
- Bastante claro
- Aptitud para principiantes
- 35/100