googleapis / googleapis/google-cloud-cpp

Respect `additional_bindings` in implicit routing

Open
#12,233 3 comments 0 reactions 0 assignees View on GitHub
cpp: generator type: feature request
Dominant language
C++
Stars
659
Forks
462
Avg merge
1d 2h
Merged PRs (30d)
89

Description

aip/4222 says:

>If the [google.api.http](https://github.com/googleapis/googleapis/blob/master/google/api/http.proto) annotation contains additional_bindings, these patterns must be parsed for additional request parameters. Fields not duplicated in the top-level (or additional_bindings) pattern must be included in request parameters, encoded in the same way.
>
> Much like URL parameters, if there is more than one key-value pair, the & character is used as the separator.

AFAICT, we ignore these.

Contributor guide

Open the contributing guide

Research direction

Start by tracing how implicit routing handles google.api.http annotations and compare that behavior with AIP-4222, especially additional_bindings. Done means additional request parameters from those patterns are parsed and encoded with the documented separator behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
api, backend-api-design
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.