googleapis / googleapis/google-api-nodejs-client

Should `sideEffects` be boolean `false` ? esbuild is complaining about it since the 128.0.0 release:

Aperta
#3,419 0 commenti 15 reazioni 1 assegnatario Rivendicata da @sofisl Vedi su GitHub
Lingua principale
TypeScript
Stelle
12.2k
Fork
2k
Merge medio
1g 9h
PR unite (30g)
24

Descrizione

Should `sideEffects` be boolean `false` ? esbuild is complaining about it since the 128.0.0 release:

```
▲ [WARNING] The value for "sideEffects" must be a boolean or an array [package.json]

./node_modules/googleapis/package.json:9:17:
9 │ "sideEffects": "false",
╵ ^

1 warning
```

[Webpack documents it](https://webpack.js.org/guides/tree-shaking/#mark-the-file-as-side-effect-free) similarly as `boolean | string[]`

_Originally posted by @mhio in https://github.com/googleapis/google-api-nodejs-client/issues/3354#issuecomment-1776999824_

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.